Incremental Adoption and Anti-Patterns Volume 07 - Advanced Application Architecture | Phase 24
Do not big-bang refactor TaskFlow migrates read/list and straightforward write paths first. Transaction-heavy or cross-feature persistence can remain direct Prisma temporarily if forcing it behind the new boundary would make correctness harder to see.
Migration path Step 1 identify repeated/complex persistence logic Step 2 define the smallest useful contract Step 3 implement Prisma adapter Step 4 bind with Nest DI token Step 5 move one service path at a time Step 6 add fake service tests Step 7 add repository integration tests Step 8 reassess remaining direct Prisma usage
Anti-patterns • One repository interface per Prisma model by default.
• A generic repository that only renames Prisma methods.
• Repositories throwing HTTP exceptions.
• Repositories deciding user permissions instead of receiving an already-decided scope.
• Mapping every field through ceremonial classes with no boundary benefit.
• Breaking transaction atomicity to keep repositories pure.
• Assuming repository means the application is database-agnostic in practice.
Success criterion The repository is successful when TasksService becomes easier to read and test while persistence correctness remains explicit. File count is not the metric.
Incremental Adoption and Anti Patterns matters because it changes a real boundary in TaskFlow. The goal is to understand the inputs, owner, observable output, and failure modes before adding more abstraction.
Restate the goal of “Incremental Adoption and Anti Patterns” as one observable behavior. Write the success signal before touching code.
Trace the boundary map: service intent → repository contract → adapter → Prisma/Postgres → domain result. Mark the one boundary this lesson changes.
Inspect the current repository state and record the exact files, route, table, or runtime involved. Avoid creating an abstraction before you can name the existing owner.
Implement the smallest vertical slice. Add one coherent change, run the narrowest verification command, and read the output before continuing.
Connect the slice to TaskFlow’s phase artifact: One TaskFlow aggregate/use case refactored behind a purposeful repository interface with real database integration tests.. Verify behavior from the outside as a user or API client would.
Create one controlled failure that is safe to reproduce. Predict the symptom first, capture evidence, locate the earliest broken boundary, then fix only that cause.
Close the reference and rebuild or explain the core change from memory. Record what you would monitor or test before trusting the same change in production.
export interface TaskRepository {
findById(id: string): Promise<Task | null>;
listForWorkspace(input: TaskListQuery): Promise<TaskPage>;
save(task: Task): Promise<void>;
}Do not copy this as a finished answer. Predict what each boundary does, type the smallest useful slice, run it, then compare the result with your prediction.
Return to the nearest observable boundary: input, network, process log, database, or rendered UI. Compare actual evidence with the predicted path.
Change one variable at a time and reproduce the original failure after the fix; otherwise you have correlation, not diagnosis.
Without copying the final source, create a second small scenario that applies “Incremental Adoption and Anti Patterns” to a different TaskFlow resource or input. Write the acceptance criteria first, implement it, and provide the evidence that each criterion is satisfied.
Unit-test service behavior with a fake only where it proves useful behavior.
Use the smallest change that demonstrates this lesson. Stop after it works and capture evidence.Mocks proving an imaginary database behavior
Predict the symptom before causing the failure. Then locate the earliest boundary where reality diverges from expectation.Why does this responsibility live here, what input does it trust, what output proves success, and what would go wrong if another layer owned it?
If your explanation is vague, repeat the boundary trace before moving on.Close the reference. Reproduce the core idea from memory or explain the exact request/data flow aloud. Then check your diff or notes for accidental shortcuts that bypass validation, authorization, error handling, or verification earned in earlier phases.